Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix clippy::redundant_clone lint violations (#36558)

Browse source 
This removes around 900 unnecessary clones, ranging from cloning a few
ints all the way to large data structures and images.

A lot of these were fixed using `cargo clippy --fix --workspace
--all-targets`, however it often breaks other lints and needs to be run
again. This was then followed up with some manual fixing.

I understand this is a large diff, but all the changes are pretty
trivial. Rust is doing some heavy lifting here for us. Once I get it up
to speed with main, I'd appreciate this getting merged rather sooner
than later.

Release Notes:

- N/A
This commit is contained in:
tidely 2025-08-20 13:20:13 +03:00 • committed by GitHub
parent cf7c64d77f
commit 7bdc99abc1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
306 changed files with 805 additions and 1102 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/language_tools/src/lsp_log.rs
View file

@ -406,10 +406,7 @@ impl LogStore {
server_state.worktree_id = Some(worktree_id);
}
if let Some(server) = server
.clone()
.filter(|_| server_state.io_logs_subscription.is_none())
{
if let Some(server) = server.filter(|_| server_state.io_logs_subscription.is_none()) {
let io_tx = self.io_tx.clone();
let server_id = server.server_id();
server_state.io_logs_subscription = Some(server.on_io(move |io_kind, message| {
@ -930,7 +927,7 @@ impl LspLogView {
let state = log_store.language_servers.get(&server_id)?;
Some(LogMenuItem {
server_id,
server_name: name.clone(),
server_name: name,
server_kind: state.kind.clone(),
worktree_root_name: "supplementary".to_string(),
rpc_trace_enabled: state.rpc_state.is_some(),
@ -1527,7 +1524,7 @@ impl Render for LspLogToolbarItemView {
.icon_color(Color::Muted),
)
.menu({
let log_view = log_view.clone();
let log_view = log_view;
move |window, cx| {
let id = log_view.read(cx).current_server_id?;
@ -1595,7 +1592,7 @@ impl Render for LspLogToolbarItemView {
.icon_color(Color::Muted),
)
.menu({
let log_view = log_view.clone();
let log_view = log_view;
move |window, cx| {
let id = log_view.read(cx).current_server_id?;

2
crates/language_tools/src/syntax_tree_view.rs
View file

@ -156,7 +156,7 @@ impl SyntaxTreeView {
.buffer_snapshot
.range_to_buffer_ranges(selection_range)
.pop()?;
let buffer = multi_buffer.buffer(buffer.remote_id()).unwrap().clone();
let buffer = multi_buffer.buffer(buffer.remote_id()).unwrap();
Some((buffer, range, excerpt_id))
})?;