Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -2427,7 +2427,7 @@ impl MultiBuffer {
|
|||
cx.emit(match event {
|
||||
language::BufferEvent::Edited => Event::Edited {
|
||||
singleton_buffer_edited: true,
|
||||
edited_buffer: Some(buffer.clone()),
|
||||
edited_buffer: Some(buffer),
|
||||
},
|
||||
language::BufferEvent::DirtyChanged => Event::DirtyChanged,
|
||||
language::BufferEvent::Saved => Event::Saved,
|
||||
|
@ -3560,9 +3560,7 @@ impl MultiBuffer {
|
|||
let multi = cx.new(|_| Self::new(Capability::ReadWrite));
|
||||
for (text, ranges) in excerpts {
|
||||
let buffer = cx.new(|cx| Buffer::local(text, cx));
|
||||
let excerpt_ranges = ranges
|
||||
.into_iter()
|
||||
.map(|range| ExcerptRange::new(range.clone()));
|
||||
let excerpt_ranges = ranges.into_iter().map(ExcerptRange::new);
|
||||
multi.update(cx, |multi, cx| {
|
||||
multi.push_excerpts(buffer, excerpt_ranges, cx)
|
||||
});
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue