Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -1394,7 +1394,7 @@ impl Session {
|
|||
let breakpoint_store = self.breakpoint_store.clone();
|
||||
if let Some((local, path)) = self.as_running_mut().and_then(|local| {
|
||||
let breakpoint = local.tmp_breakpoint.take()?;
|
||||
let path = breakpoint.path.clone();
|
||||
let path = breakpoint.path;
|
||||
Some((local, path))
|
||||
}) {
|
||||
local
|
||||
|
@ -1710,7 +1710,7 @@ impl Session {
|
|||
|
||||
this.threads = result
|
||||
.into_iter()
|
||||
.map(|thread| (ThreadId(thread.id), Thread::from(thread.clone())))
|
||||
.map(|thread| (ThreadId(thread.id), Thread::from(thread)))
|
||||
.collect();
|
||||
|
||||
this.invalidate_command_type::<StackTraceCommand>();
|
||||
|
@ -2553,10 +2553,7 @@ impl Session {
|
|||
mode: Option<String>,
|
||||
cx: &mut Context<Self>,
|
||||
) -> Task<Option<dap::DataBreakpointInfoResponse>> {
|
||||
let command = DataBreakpointInfoCommand {
|
||||
context: context.clone(),
|
||||
mode,
|
||||
};
|
||||
let command = DataBreakpointInfoCommand { context, mode };
|
||||
|
||||
self.request(command, |_, response, _| response.ok(), cx)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue