Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -2739,7 +2739,7 @@ impl GetCodeActions {
|
|||
Some(lsp::CodeActionProviderCapability::Options(CodeActionOptions {
|
||||
code_action_kinds: Some(supported_action_kinds),
|
||||
..
|
||||
})) => Some(supported_action_kinds.clone()),
|
||||
})) => Some(supported_action_kinds),
|
||||
_ => capabilities.code_action_kinds,
|
||||
}
|
||||
}
|
||||
|
@ -3793,7 +3793,7 @@ impl GetDocumentDiagnostics {
|
|||
},
|
||||
uri: lsp::Url::parse(&info.location_url.unwrap()).unwrap(),
|
||||
},
|
||||
message: info.message.clone(),
|
||||
message: info.message,
|
||||
}
|
||||
})
|
||||
.collect::<Vec<_>>();
|
||||
|
@ -4491,9 +4491,8 @@ mod tests {
|
|||
data: Some(json!({"detail": "test detail"})),
|
||||
};
|
||||
|
||||
let proto_diagnostic =
|
||||
GetDocumentDiagnostics::serialize_lsp_diagnostic(lsp_diagnostic.clone())
|
||||
.expect("Failed to serialize diagnostic");
|
||||
let proto_diagnostic = GetDocumentDiagnostics::serialize_lsp_diagnostic(lsp_diagnostic)
|
||||
.expect("Failed to serialize diagnostic");
|
||||
|
||||
let start = proto_diagnostic.start.unwrap();
|
||||
let end = proto_diagnostic.end.unwrap();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue