Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -233,7 +233,7 @@ impl PickerDelegate for ProjectSymbolsDelegate {
|
|||
}
|
||||
}
|
||||
let label = symbol.label.text.clone();
|
||||
let path = path.to_string().clone();
|
||||
let path = path.to_string();
|
||||
|
||||
let highlights = gpui::combine_highlights(
|
||||
string_match
|
||||
|
@ -257,10 +257,8 @@ impl PickerDelegate for ProjectSymbolsDelegate {
|
|||
v_flex()
|
||||
.child(
|
||||
LabelLike::new().child(
|
||||
StyledText::new(label).with_default_highlights(
|
||||
&window.text_style().clone(),
|
||||
highlights,
|
||||
),
|
||||
StyledText::new(label)
|
||||
.with_default_highlights(&window.text_style(), highlights),
|
||||
),
|
||||
)
|
||||
.child(Label::new(path).color(Color::Muted)),
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue