Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -233,8 +233,8 @@ impl SshConnectionOptions {
|
|||
};
|
||||
|
||||
Ok(Self {
|
||||
host: hostname.to_string(),
|
||||
username: username.clone(),
|
||||
host: hostname,
|
||||
username,
|
||||
port,
|
||||
port_forwards,
|
||||
args: Some(args),
|
||||
|
@ -1363,7 +1363,7 @@ impl ConnectionPool {
|
|||
|
||||
impl From<SshRemoteClient> for AnyProtoClient {
|
||||
fn from(client: SshRemoteClient) -> Self {
|
||||
AnyProtoClient::new(client.client.clone())
|
||||
AnyProtoClient::new(client.client)
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue