Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -292,12 +292,7 @@ impl NeovimBackedTestContext {
|
|||
register: '"',
|
||||
state: self.shared_state().await,
|
||||
neovim: self.neovim.read_register('"').await,
|
||||
editor: self
|
||||
.read_from_clipboard()
|
||||
.unwrap()
|
||||
.text()
|
||||
.unwrap()
|
||||
.to_owned(),
|
||||
editor: self.read_from_clipboard().unwrap().text().unwrap(),
|
||||
}
|
||||
}
|
||||
|
||||
|
|
|
@ -453,7 +453,7 @@ impl NeovimConnection {
|
|||
};
|
||||
|
||||
if self.data.back() != Some(&state) {
|
||||
self.data.push_back(state.clone());
|
||||
self.data.push_back(state);
|
||||
}
|
||||
|
||||
(mode, ranges)
|
||||
|
|
|
@ -225,7 +225,7 @@ impl VimTestContext {
|
|||
VimClipboard {
|
||||
editor: self
|
||||
.read_from_clipboard()
|
||||
.map(|item| item.text().unwrap().to_string())
|
||||
.map(|item| item.text().unwrap())
|
||||
.unwrap_or_default(),
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue