Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -1968,7 +1968,7 @@ impl LocalWorktree {
|
|||
cx: &Context<Worktree>,
|
||||
) -> Option<Task<Result<()>>> {
|
||||
let path = self.entry_for_id(entry_id).unwrap().path.clone();
|
||||
let mut rx = self.add_path_prefix_to_scan(path.clone());
|
||||
let mut rx = self.add_path_prefix_to_scan(path);
|
||||
Some(cx.background_spawn(async move {
|
||||
rx.next().await;
|
||||
Ok(())
|
||||
|
@ -3952,7 +3952,7 @@ impl BackgroundScanner {
|
|||
.iter()
|
||||
.map(|path| {
|
||||
if path.file_name().is_some() {
|
||||
root_canonical_path.as_path().join(path).to_path_buf()
|
||||
root_canonical_path.as_path().join(path)
|
||||
} else {
|
||||
root_canonical_path.as_path().to_path_buf()
|
||||
}
|
||||
|
|
|
@ -1254,7 +1254,7 @@ async fn test_create_directory_during_initial_scan(cx: &mut TestAppContext) {
|
|||
let snapshot = Arc::new(Mutex::new(tree.snapshot()));
|
||||
tree.observe_updates(0, cx, {
|
||||
let snapshot = snapshot.clone();
|
||||
let settings = tree.settings().clone();
|
||||
let settings = tree.settings();
|
||||
move |update| {
|
||||
snapshot
|
||||
.lock()
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue