Fix clippy::redundant_clone
lint violations (#36558)
This removes around 900 unnecessary clones, ranging from cloning a few ints all the way to large data structures and images. A lot of these were fixed using `cargo clippy --fix --workspace --all-targets`, however it often breaks other lints and needs to be run again. This was then followed up with some manual fixing. I understand this is a large diff, but all the changes are pretty trivial. Rust is doing some heavy lifting here for us. Once I get it up to speed with main, I'd appreciate this getting merged rather sooner than later. Release Notes: - N/A
This commit is contained in:
parent
cf7c64d77f
commit
7bdc99abc1
306 changed files with 805 additions and 1102 deletions
|
@ -526,8 +526,6 @@ fn initialize_panels(
|
|||
window: &mut Window,
|
||||
cx: &mut Context<Workspace>,
|
||||
) {
|
||||
let prompt_builder = prompt_builder.clone();
|
||||
|
||||
cx.spawn_in(window, async move |workspace_handle, cx| {
|
||||
let project_panel = ProjectPanel::load(workspace_handle.clone(), cx.clone());
|
||||
let outline_panel = OutlinePanel::load(workspace_handle.clone(), cx.clone());
|
||||
|
@ -1394,7 +1392,7 @@ fn show_keymap_file_load_error(
|
|||
cx: &mut App,
|
||||
) {
|
||||
show_markdown_app_notification(
|
||||
notification_id.clone(),
|
||||
notification_id,
|
||||
error_message,
|
||||
"Open Keymap File".into(),
|
||||
|window, cx| {
|
||||
|
@ -4786,7 +4784,7 @@ mod tests {
|
|||
cx.background_executor.run_until_parked();
|
||||
|
||||
// 5. Critical: Verify .zed is actually excluded from worktree
|
||||
let worktree = cx.update(|cx| project.read(cx).worktrees(cx).next().unwrap().clone());
|
||||
let worktree = cx.update(|cx| project.read(cx).worktrees(cx).next().unwrap());
|
||||
|
||||
let has_zed_entry = cx.update(|cx| worktree.read(cx).entry_for_path(".zed").is_some());
|
||||
|
||||
|
@ -4822,7 +4820,7 @@ mod tests {
|
|||
.await
|
||||
.unwrap();
|
||||
|
||||
let new_content_str = new_content.clone();
|
||||
let new_content_str = new_content;
|
||||
eprintln!("New settings content: {}", new_content_str);
|
||||
|
||||
// The bug causes the settings to be overwritten with empty settings
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue