Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

file_finder: Notify user when picker an non-utf8 file (#18136)

Browse source 
notify user when using file finder picker an file which cannot open.

Release Notes:

- N/A
This commit is contained in:
CharlesChen0823 2024-09-21 03:49:40 +08:00 • committed by GitHub
parent 45388805ad
commit 7d62fda5a3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/file_finder/src/file_finder.rs
View file

@ -31,7 +31,7 @@ use std::{
use text::Point; use text::Point;
use ui::{prelude::*, HighlightedLabel, ListItem, ListItemSpacing}; use ui::{prelude::*, HighlightedLabel, ListItem, ListItemSpacing};
use util::{paths::PathWithPosition, post_inc, ResultExt}; use util::{paths::PathWithPosition, post_inc, ResultExt};
use workspace::{item::PreviewTabsSettings, ModalView, Workspace}; use workspace::{item::PreviewTabsSettings, notifications::NotifyResultExt, ModalView, Workspace};
actions!(file_finder, [SelectPrev]); actions!(file_finder, [SelectPrev]);
@ -1011,7 +1011,7 @@ impl PickerDelegate for FileFinderDelegate {
let finder = self.file_finder.clone(); let finder = self.file_finder.clone();
cx.spawn(|_, mut cx| async move { cx.spawn(|_, mut cx| async move {
let item = open_task.await.log_err()?; let item = open_task.await.notify_async_err(&mut cx)?;
if let Some(row) = row { if let Some(row) = row {
if let Some(active_editor) = item.downcast::<Editor>() { if let Some(active_editor) = item.downcast::<Editor>() {
active_editor active_editor