Rework context insertion UX (#12360)

- Confirming a completion now runs the command immediately
- Hitting `enter` on a line with a command now runs it
- The output of commands gets folded away and replaced with a custom
placeholder
- Eliminated ambient context

<img width="1588" alt="image"
src="https://github.com/zed-industries/zed/assets/482957/b1927a45-52d6-4634-acc9-2ee539c1d89a">

Release Notes:

- N/A

---------

Co-authored-by: Nathan Sobo <nathan@zed.dev>

crates/extension/Cargo.toml

@@ -46,6 +46,7 @@ wasmtime.workspace = true
 wasmtime-wasi.workspace = true
 wasmparser.workspace = true
 wit-component.workspace = true
+workspace.workspace = true
 task.workspace = true
 serde_json_lenient.workspace = true
 
@@ -58,3 +59,4 @@ fs = { workspace = true, features = ["test-support"] }
 gpui = { workspace = true, features = ["test-support"] }
 language = { workspace = true, features = ["test-support"] }
 project = { workspace = true, features = ["test-support"] }
+workspace = { workspace = true, features = ["test-support"] }

crates/extension/src/extension_manifest.rs

@@ -133,6 +133,7 @@ impl LanguageServerManifestEntry {
 #[derive(Clone, PartialEq, Eq, Debug, Deserialize, Serialize)]
 pub struct SlashCommandManifestEntry {
     pub description: String,
+    pub tooltip_text: String,
     pub requires_argument: bool,
 }
 

crates/extension/src/extension_slash_command.rs

@@ -1,15 +1,12 @@
-use std::sync::atomic::AtomicBool;
-use std::sync::Arc;
-
-use anyhow::{anyhow, Result};
-use assistant_slash_command::{SlashCommand, SlashCommandCleanup, SlashCommandInvocation};
-use futures::channel::oneshot;
-use futures::FutureExt;
-use gpui::{AppContext, Task};
-use language::LspAdapterDelegate;
-use wasmtime_wasi::WasiView;
-
 use crate::wasm_host::{WasmExtension, WasmHost};
+use anyhow::{anyhow, Result};
+use assistant_slash_command::{SlashCommand, SlashCommandOutput};
+use futures::FutureExt;
+use gpui::{AppContext, IntoElement, Task, WeakView, WindowContext};
+use language::LspAdapterDelegate;
+use std::sync::{atomic::AtomicBool, Arc};
+use wasmtime_wasi::WasiView;
+use workspace::Workspace;
 
 pub struct ExtensionSlashCommand {
     pub(crate) extension: WasmExtension,
@@ -27,6 +24,10 @@ impl SlashCommand for ExtensionSlashCommand {
         self.command.description.clone()
     }
 
+    fn tooltip_text(&self) -> String {
+        self.command.tooltip_text.clone()
+    }
+
     fn requires_argument(&self) -> bool {
         self.command.requires_argument
     }
@@ -43,11 +44,11 @@ impl SlashCommand for ExtensionSlashCommand {
     fn run(
         self: Arc<Self>,
         argument: Option<&str>,
+        _workspace: WeakView<Workspace>,
         delegate: Arc<dyn LspAdapterDelegate>,
-        cx: &mut AppContext,
-    ) -> SlashCommandInvocation {
+        cx: &mut WindowContext,
+    ) -> Task<Result<SlashCommandOutput>> {
         let argument = argument.map(|arg| arg.to_string());
-
         let output = cx.background_executor().spawn(async move {
             let output = self
                 .extension
@@ -72,14 +73,16 @@ impl SlashCommand for ExtensionSlashCommand {
                     }
                 })
                 .await?;
-
             output.ok_or_else(|| anyhow!("no output from command: {}", self.command.name))
         });
-
-        SlashCommandInvocation {
-            output,
-            invalidated: oneshot::channel().1,
-            cleanup: SlashCommandCleanup::default(),
-        }
+        cx.foreground_executor().spawn(async move {
+            let output = output.await?;
+            Ok(SlashCommandOutput {
+                text: output,
+                render_placeholder: Arc::new(|_, _, _| {
+                    "TODO: Extension command output".into_any_element()
+                }),
+            })
+        })
     }
 }

crates/extension/src/extension_store.rs

@@ -1183,6 +1183,7 @@ impl ExtensionStore {
                                 command: crate::wit::SlashCommand {
                                     name: slash_command_name.to_string(),
                                     description: slash_command.description.to_string(),
+                                    tooltip_text: slash_command.tooltip_text.to_string(),
                                     requires_argument: slash_command.requires_argument,
                                 },
                                 extension: wasm_extension.clone(),