From 7efa8d079de70470aa323e3162a7e4557a1eab3c Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Wed, 28 Feb 2024 18:39:54 +0100 Subject: [PATCH] Do not set rules by default for eslint (#8545) Follow-up to and fix for #8537. Turns out that if you set `rules: []` it doesn't mean "no matchers", but it means "no rules". So let's not set a default here. Release Notes: - N/A, see #8537 Co-authored-by: Conrad --- crates/languages/src/typescript.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/crates/languages/src/typescript.rs b/crates/languages/src/typescript.rs index 395900df93..2370dd991f 100644 --- a/crates/languages/src/typescript.rs +++ b/crates/languages/src/typescript.rs @@ -241,7 +241,6 @@ impl LspAdapter for EsLintLspAdapter { // We enable this, but without also configuring `code_actions_on_format` // in the Zed configuration, it doesn't have an effect. "enable": true, - "rules": [] }); if let Some(code_action_settings) = eslint_user_settings