debugger beta: Fix panic that could occur when parsing an invalid dap schema (#31175)
Release Notes: - N/A
This commit is contained in:
parent
06f725d51b
commit
80a00cd241
4 changed files with 21 additions and 6 deletions
|
@ -2,6 +2,7 @@ use adapters::latest_github_release;
|
|||
use anyhow::Context as _;
|
||||
use anyhow::bail;
|
||||
use dap::StartDebuggingRequestArguments;
|
||||
use dap::StartDebuggingRequestArgumentsRequest;
|
||||
use dap::adapters::{DebugTaskDefinition, TcpArguments};
|
||||
use gpui::{AsyncApp, SharedString};
|
||||
use language::LanguageName;
|
||||
|
@ -46,6 +47,13 @@ impl PhpDebugAdapter {
|
|||
})
|
||||
}
|
||||
|
||||
fn validate_config(
|
||||
&self,
|
||||
_: &serde_json::Value,
|
||||
) -> Result<StartDebuggingRequestArgumentsRequest> {
|
||||
Ok(StartDebuggingRequestArgumentsRequest::Launch)
|
||||
}
|
||||
|
||||
async fn get_installed_binary(
|
||||
&self,
|
||||
delegate: &Arc<dyn DapDelegate>,
|
||||
|
@ -93,7 +101,7 @@ impl PhpDebugAdapter {
|
|||
envs: HashMap::default(),
|
||||
request_args: StartDebuggingRequestArguments {
|
||||
configuration: task_definition.config.clone(),
|
||||
request: dap::StartDebuggingRequestArgumentsRequest::Launch,
|
||||
request: self.validate_config(&task_definition.config)?,
|
||||
},
|
||||
})
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue