Prototype cursor sharing (the inefficient way)
I think this will be a key user experience driver, but we do need to find a way to enable it without widening our vector clocks.
This commit is contained in:
parent
ca0c06b577
commit
82f7dd9bbb
2 changed files with 19 additions and 4 deletions
|
@ -883,6 +883,7 @@ impl Database {
|
|||
&self,
|
||||
project_id: ProjectId,
|
||||
connection_id: ConnectionId,
|
||||
requires_write: bool,
|
||||
) -> Result<RoomGuard<Vec<ProjectCollaborator>>> {
|
||||
let room_id = self.room_id_for_project(project_id).await?;
|
||||
self.room_transaction(room_id, |tx| async move {
|
||||
|
@ -893,7 +894,8 @@ impl Database {
|
|||
.await?
|
||||
.ok_or_else(|| anyhow!("no such room"))?;
|
||||
|
||||
if !current_participant
|
||||
if requires_write
|
||||
&& !current_participant
|
||||
.role
|
||||
.map_or(false, |role| role.can_edit_projects())
|
||||
{
|
||||
|
|
|
@ -1814,11 +1814,24 @@ async fn update_buffer(
|
|||
let mut guest_connection_ids;
|
||||
let mut host_connection_id = None;
|
||||
|
||||
let mut requires_write_permission = false;
|
||||
|
||||
for op in request.operations.iter() {
|
||||
match op.variant {
|
||||
None | Some(proto::operation::Variant::UpdateSelections(_)) => {}
|
||||
Some(_) => requires_write_permission = true,
|
||||
}
|
||||
}
|
||||
|
||||
{
|
||||
let collaborators = session
|
||||
.db()
|
||||
.await
|
||||
.project_collaborators_for_buffer_update(project_id, session.connection_id)
|
||||
.project_collaborators_for_buffer_update(
|
||||
project_id,
|
||||
session.connection_id,
|
||||
requires_write_permission,
|
||||
)
|
||||
.await?;
|
||||
guest_connection_ids = Vec::with_capacity(collaborators.len() - 1);
|
||||
for collaborator in collaborators.iter() {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue