Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

language: Don't add final newline on format for an empty buffer (#32320)

Browse source 
Closes #32313

Release Notes:

- Fixed newline getting added on format to empty files
This commit is contained in:
Evan Simkowitz 2025-06-09 06:00:17 -07:00 • committed by GitHub
parent afab4b522e
commit 8332e60ca9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/language/src/buffer.rs
View file

@ -1874,9 +1874,12 @@ impl Buffer {
} }
/// Ensures that the buffer ends with a single newline character, and /// Ensures that the buffer ends with a single newline character, and
/// no other whitespace. /// no other whitespace. Skips if the buffer is empty.
pub fn ensure_final_newline(&mut self, cx: &mut Context<Self>) { pub fn ensure_final_newline(&mut self, cx: &mut Context<Self>) {
let len = self.len(); let len = self.len();
if len == 0 {
return;
}
let mut offset = len; let mut offset = len;
for chunk in self.as_rope().reversed_chunks_in_range(0..len) { for chunk in self.as_rope().reversed_chunks_in_range(0..len) {
let non_whitespace_len = chunk let non_whitespace_len = chunk