Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Store goldenfiles with trailing newline (#10900)

Browse source 
Release Notes:


- N/A
This commit is contained in:
Thorsten Ball 2024-04-23 19:13:04 +02:00 • committed by GitHub
parent 2ee257a562
commit 85b26e9788
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/git/src/blame.rs
View file

@ -336,8 +336,10 @@ mod tests {
path.push("golden"); path.push("golden");
path.push(format!("{}.json", golden_filename)); path.push(format!("{}.json", golden_filename));
let have_json = let mut have_json =
serde_json::to_string_pretty(&entries).expect("could not serialize entries to JSON"); serde_json::to_string_pretty(&entries).expect("could not serialize entries to JSON");
// We always want to save with a trailing newline.
have_json.push('\n');
let update = std::env::var("UPDATE_GOLDEN") let update = std::env::var("UPDATE_GOLDEN")
.map(|val| val.to_ascii_lowercase() == "true") .map(|val| val.to_ascii_lowercase() == "true")

2
crates/git/test_data/golden/blame_incremental_complex.json
View file

@ -778,4 +778,4 @@
"previous": null, "previous": null,
"filename": "crates/vim/src/utils.rs" "filename": "crates/vim/src/utils.rs"
} }
] ]

2
crates/git/test_data/golden/blame_incremental_not_committed.json
View file

@ -132,4 +132,4 @@
"previous": null, "previous": null,
"filename": "file_b.txt" "filename": "file_b.txt"
} }
] ]

2
crates/git/test_data/golden/blame_incremental_simple.json
View file

@ -132,4 +132,4 @@
"previous": null, "previous": null,
"filename": "index.js" "filename": "index.js"
} }
] ]