debugger: Fix gdb adapter and logger (#28280)
There were two bugs that caused the gdb adapter not to work properly, one on our end and one their end. The bug on our end was sending `stopOnEntry: null` in our launch request when stop on entry had no value. I fixed that bug across all dap adapters The other bug had to do with python's "great" type system and how we serialized our unit structs to json; mainly, `ConfigurationDoneArguments` and `ThreadsArguments`. Gdb seems to follow a pattern for handling requests where they pass `**args` to a function, this errors out when the equivalent json is `"arguments": null`. ```py @capability("supportsConfigurationDoneRequest") @request("configurationDone", on_dap_thread=True) def config_done(**args): ### BUG!! ... ``` Release Notes: - N/A
This commit is contained in:
parent
56ed5dcc89
commit
862d0c07ca
13 changed files with 120 additions and 64 deletions
|
@ -1479,7 +1479,7 @@ impl LocalDapCommand for ThreadsCommand {
|
|||
type DapRequest = dap::requests::Threads;
|
||||
|
||||
fn to_dap(&self) -> <Self::DapRequest as dap::requests::Request>::Arguments {
|
||||
()
|
||||
dap::ThreadsArgument {}
|
||||
}
|
||||
|
||||
fn response_from_dap(
|
||||
|
@ -1568,7 +1568,7 @@ impl LocalDapCommand for Initialize {
|
|||
}
|
||||
|
||||
#[derive(Clone, Debug, Hash, PartialEq)]
|
||||
pub(super) struct ConfigurationDone;
|
||||
pub(super) struct ConfigurationDone {}
|
||||
|
||||
impl LocalDapCommand for ConfigurationDone {
|
||||
type Response = ();
|
||||
|
@ -1581,7 +1581,7 @@ impl LocalDapCommand for ConfigurationDone {
|
|||
}
|
||||
|
||||
fn to_dap(&self) -> <Self::DapRequest as dap::requests::Request>::Arguments {
|
||||
dap::ConfigurationDoneArguments
|
||||
dap::ConfigurationDoneArguments {}
|
||||
}
|
||||
|
||||
fn response_from_dap(
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue