From 8730d317a8fa1a11f5b4502f41b943a2c9f61305 Mon Sep 17 00:00:00 2001 From: Oleksiy Syvokon Date: Thu, 5 Jun 2025 20:14:39 +0300 Subject: [PATCH] themes: Swap ANSI white with ANSI black (#32175) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Here’s how it looks after the fix: ![colors](https://github.com/user-attachments/assets/11c78ad6-da50-4aad-b133-9be5e3844878). White is white and black is black, as intended. In some cases, dimmed colors were poorly defined, so I took `text.dimmed` values. Note that white is defined exactly as the background color for light themes. Similarly, black is the exact background color for dark themes. I didn’t change this, but many themes intentionally make white and black slightly different from the background color. This prevents issues where programs assume, say, a dark background and set the foreground to white, making text invisible. I'm not sure if we want to adjust these themes to address this; just noting it here. Closes #29379 Release Notes: - Fixed ANSI black and ANSI white colors in built-in themes --- assets/themes/ayu/ayu.json | 12 +++++----- assets/themes/gruvbox/gruvbox.json | 36 +++++++++++++++--------------- assets/themes/one/one.json | 12 +++++----- 3 files changed, 30 insertions(+), 30 deletions(-) diff --git a/assets/themes/ayu/ayu.json b/assets/themes/ayu/ayu.json index 745eb2b4c2..de659dbe29 100644 --- a/assets/themes/ayu/ayu.json +++ b/assets/themes/ayu/ayu.json @@ -442,9 +442,9 @@ "terminal.foreground": "#5c6166ff", "terminal.bright_foreground": "#5c6166ff", "terminal.dim_foreground": "#fcfcfcff", - "terminal.ansi.black": "#fcfcfcff", - "terminal.ansi.bright_black": "#bcbec0ff", - "terminal.ansi.dim_black": "#5c6166ff", + "terminal.ansi.black": "#5c6166ff", + "terminal.ansi.bright_black": "#3b9ee5ff", + "terminal.ansi.dim_black": "#9c9fa2ff", "terminal.ansi.red": "#ef7271ff", "terminal.ansi.bright_red": "#febab6ff", "terminal.ansi.dim_red": "#833538ff", @@ -463,9 +463,9 @@ "terminal.ansi.cyan": "#4dbf99ff", "terminal.ansi.bright_cyan": "#ace0cbff", "terminal.ansi.dim_cyan": "#2a5f4aff", - "terminal.ansi.white": "#5c6166ff", - "terminal.ansi.bright_white": "#5c6166ff", - "terminal.ansi.dim_white": "#9c9fa2ff", + "terminal.ansi.white": "#fcfcfcff", + "terminal.ansi.bright_white": "#fcfcfcff", + "terminal.ansi.dim_white": "#bcbec0ff", "link_text.hover": "#3b9ee5ff", "conflict": "#f1ad49ff", "conflict.background": "#ffeedaff", diff --git a/assets/themes/gruvbox/gruvbox.json b/assets/themes/gruvbox/gruvbox.json index 7fc89d2238..fbbec82793 100644 --- a/assets/themes/gruvbox/gruvbox.json +++ b/assets/themes/gruvbox/gruvbox.json @@ -1227,9 +1227,9 @@ "terminal.foreground": "#282828ff", "terminal.bright_foreground": "#282828ff", "terminal.dim_foreground": "#fbf1c7ff", - "terminal.ansi.black": "#fbf1c7ff", - "terminal.ansi.bright_black": "#b0a189ff", - "terminal.ansi.dim_black": "#282828ff", + "terminal.ansi.black": "#282828ff", + "terminal.ansi.bright_black": "#0b6678ff", + "terminal.ansi.dim_black": "#5f5650ff", "terminal.ansi.red": "#9d0308ff", "terminal.ansi.bright_red": "#db8b7aff", "terminal.ansi.dim_red": "#4e1207ff", @@ -1248,9 +1248,9 @@ "terminal.ansi.cyan": "#437b59ff", "terminal.ansi.bright_cyan": "#9fbca8ff", "terminal.ansi.dim_cyan": "#253e2eff", - "terminal.ansi.white": "#282828ff", - "terminal.ansi.bright_white": "#282828ff", - "terminal.ansi.dim_white": "#73675eff", + "terminal.ansi.white": "#fbf1c7ff", + "terminal.ansi.bright_white": "#fbf1c7ff", + "terminal.ansi.dim_white": "#b0a189ff", "link_text.hover": "#0b6678ff", "version_control.added": "#797410ff", "version_control.modified": "#b57615ff", @@ -1612,9 +1612,9 @@ "terminal.foreground": "#282828ff", "terminal.bright_foreground": "#282828ff", "terminal.dim_foreground": "#f9f5d7ff", - "terminal.ansi.black": "#f9f5d7ff", - "terminal.ansi.bright_black": "#b0a189ff", - "terminal.ansi.dim_black": "#282828ff", + "terminal.ansi.black": "#282828ff", + "terminal.ansi.bright_black": "#73675eff", + "terminal.ansi.dim_black": "#f9f5d7ff", "terminal.ansi.red": "#9d0308ff", "terminal.ansi.bright_red": "#db8b7aff", "terminal.ansi.dim_red": "#4e1207ff", @@ -1633,9 +1633,9 @@ "terminal.ansi.cyan": "#437b59ff", "terminal.ansi.bright_cyan": "#9fbca8ff", "terminal.ansi.dim_cyan": "#253e2eff", - "terminal.ansi.white": "#282828ff", - "terminal.ansi.bright_white": "#282828ff", - "terminal.ansi.dim_white": "#73675eff", + "terminal.ansi.white": "#f9f5d7ff", + "terminal.ansi.bright_white": "#f9f5d7ff", + "terminal.ansi.dim_white": "#b0a189ff", "link_text.hover": "#0b6678ff", "version_control.added": "#797410ff", "version_control.modified": "#b57615ff", @@ -1997,9 +1997,9 @@ "terminal.foreground": "#282828ff", "terminal.bright_foreground": "#282828ff", "terminal.dim_foreground": "#f2e5bcff", - "terminal.ansi.black": "#f2e5bcff", - "terminal.ansi.bright_black": "#b0a189ff", - "terminal.ansi.dim_black": "#282828ff", + "terminal.ansi.black": "#282828ff", + "terminal.ansi.bright_black": "#73675eff", + "terminal.ansi.dim_black": "#f2e5bcff", "terminal.ansi.red": "#9d0308ff", "terminal.ansi.bright_red": "#db8b7aff", "terminal.ansi.dim_red": "#4e1207ff", @@ -2018,9 +2018,9 @@ "terminal.ansi.cyan": "#437b59ff", "terminal.ansi.bright_cyan": "#9fbca8ff", "terminal.ansi.dim_cyan": "#253e2eff", - "terminal.ansi.white": "#282828ff", - "terminal.ansi.bright_white": "#282828ff", - "terminal.ansi.dim_white": "#73675eff", + "terminal.ansi.white": "#f2e5bcff", + "terminal.ansi.bright_white": "#f2e5bcff", + "terminal.ansi.dim_white": "#b0a189ff", "link_text.hover": "#0b6678ff", "version_control.added": "#797410ff", "version_control.modified": "#b57615ff", diff --git a/assets/themes/one/one.json b/assets/themes/one/one.json index 275144d36d..b0455f208a 100644 --- a/assets/themes/one/one.json +++ b/assets/themes/one/one.json @@ -450,9 +450,9 @@ "terminal.foreground": "#242529ff", "terminal.bright_foreground": "#242529ff", "terminal.dim_foreground": "#fafafaff", - "terminal.ansi.black": "#fafafaff", - "terminal.ansi.bright_black": "#aaaaaaff", - "terminal.ansi.dim_black": "#242529ff", + "terminal.ansi.black": "#242529ff", + "terminal.ansi.bright_black": "#242529ff", + "terminal.ansi.dim_black": "#97979aff", "terminal.ansi.red": "#d36151ff", "terminal.ansi.bright_red": "#f0b0a4ff", "terminal.ansi.dim_red": "#6f312aff", @@ -471,9 +471,9 @@ "terminal.ansi.cyan": "#3a82b7ff", "terminal.ansi.bright_cyan": "#a3bedaff", "terminal.ansi.dim_cyan": "#254058ff", - "terminal.ansi.white": "#242529ff", - "terminal.ansi.bright_white": "#242529ff", - "terminal.ansi.dim_white": "#97979aff", + "terminal.ansi.white": "#fafafaff", + "terminal.ansi.bright_white": "#fafafaff", + "terminal.ansi.dim_white": "#aaaaaaff", "link_text.hover": "#5c78e2ff", "version_control.added": "#27a657ff", "version_control.modified": "#d3b020ff",