Re-applies what's been reverted in https://github.com/zed-industries/zed/pull/26832 with an action-related fix in64b5d37d32
Before, actions were resolved only if `data` is present and either of the possible fields is empty:e842b4eade/crates/project/src/lsp_store.rs (L1632-L1633)
But Zed resolves completions and inlays once, unconditionally, and the reverted PR applied the same strategy to actions. That did not work despite the spec not forbidding `data`-less actions to be resolved. Soon, it starts to work due to https://github.com/rust-lang/rust-analyzer/pull/19369 but it seems safer to restore the original filtering code. Code lens have no issues with `data`-less resolves:220d913cbc/crates/rust-analyzer/src/handlers/request.rs (L1618-L1620)
so the same approach as completions and inlays is kept: resolve once. Release Notes: - N/A
This commit is contained in:
parent
ef91e7afae
commit
8a31dcaeb0
13 changed files with 618 additions and 17 deletions
|
@ -7,7 +7,7 @@ use gpui::{App, AsyncApp, Task};
|
|||
use http_client::github::AssetKind;
|
||||
use http_client::github::{latest_github_release, GitHubLspBinaryVersion};
|
||||
pub use language::*;
|
||||
use lsp::{LanguageServerBinary, LanguageServerName};
|
||||
use lsp::LanguageServerBinary;
|
||||
use regex::Regex;
|
||||
use smol::fs::{self};
|
||||
use std::fmt::Display;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue