One big cleanup pass of clippy lints

Co-authored-by: Mikayla <mikayla@zed.dev>

crates/zed/src/languages/c.rs

@@ -116,7 +116,7 @@ impl super::LspAdapter for CLspAdapter {
     ) -> Option<CodeLabel> {
         let label = completion
             .label
-            .strip_prefix("•")
+            .strip_prefix('•')
             .unwrap_or(&completion.label)
             .trim();
 

crates/zed/src/languages/go.rs

@@ -72,7 +72,7 @@ impl super::LspAdapter for GoLspAdapter {
                 }
             }
         } else if let Some(path) = this.cached_server_binary(container_dir.clone()).await {
-            return Ok(path.to_path_buf());
+            return Ok(path);
         }
 
         let gobin_dir = container_dir.join("gobin");
@@ -122,7 +122,7 @@ impl super::LspAdapter for GoLspAdapter {
             }
 
             if let Some(path) = last_binary_path {
-                Ok(path.to_path_buf())
+                Ok(path)
             } else {
                 Err(anyhow!("no cached binary"))
             }
@@ -141,7 +141,7 @@ impl super::LspAdapter for GoLspAdapter {
         // Gopls returns nested fields and methods as completions.
         // To syntax highlight these, combine their final component
         // with their detail.
-        let name_offset = label.rfind(".").unwrap_or(0);
+        let name_offset = label.rfind('.').unwrap_or(0);
 
         match completion.kind.zip(completion.detail.as_ref()) {
             Some((lsp::CompletionItemKind::MODULE, detail)) => {

crates/zed/src/languages/python.rs

@@ -206,7 +206,7 @@ mod tests {
             );
 
             // dedent the closing paren if it is shifted to the beginning of the line
-            let argument_ix = buffer.text().find("1").unwrap();
+            let argument_ix = buffer.text().find('1').unwrap();
             buffer.edit(
                 [(argument_ix..argument_ix + 1, "")],
                 Some(AutoindentMode::EachLine),

crates/zed/src/languages/typescript.rs

@@ -65,7 +65,7 @@ impl LspAdapter for TypeScriptLspAdapter {
                     ("typescript", versions.typescript_version.as_str()),
                     (
                         "typescript-language-server",
-                        &versions.server_version.as_str(),
+                        versions.server_version.as_str(),
                     ),
                 ],
                 &version_dir,