Enable clippy::to_string_in_format_args (#8732)

This PR enables the
[`clippy::to_string_in_format_args`](https://rust-lang.github.io/rust-clippy/master/index.html#/to_string_in_format_args)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-02 18:13:49 -05:00 committed by GitHub
parent 52052f342b
commit 8bc35c33c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 3 additions and 4 deletions

View file

@ -841,7 +841,7 @@ mod tests {
surrounding_word(&snapshot, display_points[1]),
display_points[0]..display_points[2],
"{}",
marked_text.to_string()
marked_text
);
}

View file

@ -236,7 +236,7 @@ impl EditorTestContext {
pub fn set_state(&mut self, marked_text: &str) -> ContextHandle {
let state_context = self.add_assertion_context(format!(
"Initial Editor State: \"{}\"",
marked_text.escape_debug().to_string()
marked_text.escape_debug()
));
let (unmarked_text, selection_ranges) = marked_text_ranges(marked_text, true);
self.editor.update(&mut self.cx, |editor, cx| {
@ -252,7 +252,7 @@ impl EditorTestContext {
pub fn set_selections_state(&mut self, marked_text: &str) -> ContextHandle {
let state_context = self.add_assertion_context(format!(
"Initial Editor State: \"{}\"",
marked_text.escape_debug().to_string()
marked_text.escape_debug()
));
let (unmarked_text, selection_ranges) = marked_text_ranges(marked_text, true);
self.editor.update(&mut self.cx, |editor, cx| {

View file

@ -124,7 +124,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
"clippy::search_is_some",
"clippy::single_range_in_vec_init",
"clippy::suspicious_to_owned",
"clippy::to_string_in_format_args",
"clippy::too_many_arguments",
"clippy::type_complexity",
"clippy::unit_arg",