Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

pane: Fix rough edges around pinning of dropped project entries (#20722)

Browse source 
Closes #20485

Release Notes:

- Fixed quirks around dropping project entries into tab bar which
might've led to tabs being pinned sometimes.
This commit is contained in:
Piotr Osiewicz 2024-11-15 13:51:40 +01:00 • committed by GitHub
parent 1e14697bb6
commit 8c02929710
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 35 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
crates/workspace/src/workspace.rs
View file

@ -1406,6 +1406,7 @@ impl Workspace {
project_entry_id,
true,
entry.is_preview,
None,
cx,
build_item,
);
@ -2621,7 +2622,14 @@ impl Workspace {
cx.spawn(move |mut cx| async move {
let (project_entry_id, build_item) = task.await?;
pane.update(&mut cx, |pane, cx| {
pane.open_item(project_entry_id, focus_item, allow_preview, cx, build_item)
pane.open_item(
project_entry_id,
focus_item,
allow_preview,
None,
cx,
build_item,
)
})
})
}
@ -2662,7 +2670,14 @@ impl Workspace {
let new_pane =
this.split_pane(pane, split_direction.unwrap_or(SplitDirection::Right), cx);
new_pane.update(cx, |new_pane, cx| {
Some(new_pane.open_item(project_entry_id, true, allow_preview, cx, build_item))
Some(new_pane.open_item(
project_entry_id,
true,
allow_preview,
None,
cx,
build_item,
))
})
})
.map(|option| option.ok_or_else(|| anyhow!("pane was dropped")))?