Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

languages: Don't remove old artifacts on download failure (#35967)

Browse source 
Release Notes:

- N/A
This commit is contained in:
Lukas Wirth 2025-08-11 09:20:03 +02:00 • committed by GitHub
parent c82cd0c6b1
commit 8d332da4c5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 35 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/languages/src/github_download.rs
View file

@ -18,9 +18,8 @@ impl GithubBinaryMetadata {
let metadata_content = async_fs::read_to_string(metadata_path)
.await
.with_context(|| format!("reading metadata file at {metadata_path:?}"))?;
let metadata: GithubBinaryMetadata = serde_json::from_str(&metadata_content)
.with_context(|| format!("parsing metadata file at {metadata_path:?}"))?;
Ok(metadata)
serde_json::from_str(&metadata_content)
.with_context(|| format!("parsing metadata file at {metadata_path:?}"))
}
pub(crate) async fn write_to_file(&self, metadata_path: &Path) -> Result<()> {
@ -63,11 +62,6 @@ pub(crate) async fn download_server_binary(
})?;
let asset_sha_256 = format!("{:x}", writer.hasher.finalize());
// Strip "sha256:" prefix for comparison
let expected_sha_256 = expected_sha_256
.strip_prefix("sha256:")
.unwrap_or(expected_sha_256);
anyhow::ensure!(
asset_sha_256 == expected_sha_256,
"{url} asset got SHA-256 mismatch. Expected: {expected_sha_256}, Got: {asset_sha_256}",