Have read_file support images (#30435)
This is very basic support for them. There are a number of other TODOs before this is really a first-class supported feature, so not adding any release notes for it; for now, this PR just makes it so that if read_file tries to read a PNG (which has come up in practice), it at least correctly sends it to Anthropic instead of messing up. This also lays the groundwork for future PRs for more first-class support for images in tool calls across more image file formats and LLM providers. Release Notes: - N/A --------- Co-authored-by: Agus Zubiaga <hi@aguz.me> Co-authored-by: Agus Zubiaga <agus@zed.dev>
This commit is contained in:
parent
f01af006e1
commit
8fdf309a4a
30 changed files with 557 additions and 194 deletions
|
@ -2,7 +2,7 @@
|
|||
/// The tests in this file assume that server_cx is running on Windows too.
|
||||
/// We neead to find a way to test Windows-Non-Windows interactions.
|
||||
use crate::headless_project::HeadlessProject;
|
||||
use assistant_tool::Tool as _;
|
||||
use assistant_tool::{Tool as _, ToolResultContent};
|
||||
use assistant_tools::{ReadFileTool, ReadFileToolInput};
|
||||
use client::{Client, UserStore};
|
||||
use clock::FakeSystemClock;
|
||||
|
@ -1593,7 +1593,7 @@ async fn test_remote_agent_fs_tool_calls(cx: &mut TestAppContext, server_cx: &mu
|
|||
)
|
||||
});
|
||||
let output = exists_result.output.await.unwrap().content;
|
||||
assert_eq!(output, "B");
|
||||
assert_eq!(output, ToolResultContent::Text("B".to_string()));
|
||||
|
||||
let input = ReadFileToolInput {
|
||||
path: "project/c.txt".into(),
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue