Replace todo calls with error values in linux/platform (#8531)

We currently use a mix of unimplemented methods with empty bodies and
`todo!()` calls in linux/platform.

`todo!()`s cause crashes in runtime with accidental key presses or
clicks.

To avoid this, this PR replaces `todo!()`s in linux/platform with error
values.

This helps when working on Zed itself, testing PRs etc.

Release Notes:

- N/A
This commit is contained in:
Ömer Sinan Ağacan 2024-03-03 20:18:08 +01:00 committed by GitHub
parent 69e0474ebb
commit 9095a6b04e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -321,8 +321,11 @@ impl Platform for LinuxPlatform {
})
}
//todo!(linux)
fn app_path(&self) -> Result<PathBuf> {
unimplemented!()
Err(anyhow::Error::msg(
"Platform<LinuxPlatform>::app_path is not implemented yet",
))
}
// todo(linux)
@ -332,8 +335,11 @@ impl Platform for LinuxPlatform {
UtcOffset::UTC
}
//todo!(linux)
fn path_for_auxiliary_executable(&self, name: &str) -> Result<PathBuf> {
unimplemented!()
Err(anyhow::Error::msg(
"Platform<LinuxPlatform>::path_for_auxiliary_executable is not implemented yet",
))
}
// todo(linux)
@ -352,16 +358,25 @@ impl Platform for LinuxPlatform {
None
}
//todo!(linux)
fn write_credentials(&self, url: &str, username: &str, password: &[u8]) -> Task<Result<()>> {
unimplemented!()
Task::Ready(Some(Err(anyhow::Error::msg(
"Platform<LinuxPlatform>::with_credentials is not implemented yet",
))))
}
//todo!(linux)
fn read_credentials(&self, url: &str) -> Task<Result<Option<(String, Vec<u8>)>>> {
unimplemented!()
Task::Ready(Some(Err(anyhow::Error::msg(
"Platform<LinuxPlatform>::read_credentials is not implemented yet",
))))
}
//todo!(linux)
fn delete_credentials(&self, url: &str) -> Task<Result<()>> {
unimplemented!()
Task::Ready(Some(Err(anyhow::Error::msg(
"Platform<LinuxPlatform>::delete_credentials is not implemented yet",
))))
}
fn window_appearance(&self) -> crate::WindowAppearance {