Simplify BufferStore's local vs remote state (#21180)

Browse source

This is a pure refactor, motivated by wanting to introduce to the
BufferStore new logic for opening staged and committed changes.

I found the `BufferStoreImpl` trait a little bit confusing, particularly
how the different implementors of the trait held a handle back to the
owning buffer store. I was able to reduce the amount of code
considerably (-78 lines) by using a two-variant enum instead, similar to
what we do for `LspStore`, `WorktreeStore` and `Worktree`.

Release Notes:

- N/A

...

This commit is contained in:

Max Brunsfeld 2024-11-25 12:53:23 -08:00 • committed by GitHub

parent a02684b2f7

commit 91a565f5fa

No known key found for this signature in database

GPG key ID: B5690EEEBB952194

1 changed files with 330 additions and 408 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

738

crates/project/src/buffer_store.rs

View file

File diff suppressed because it is too large Load diff