Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

debugger: Improve performance with large # of output (#33874)

Browse source 
Closes #33820

Release Notes:

- Improved performance of debug console when there are lots of output
events.

---------

Co-authored-by: Cole Miller <cole@zed.dev>
This commit is contained in:
Piotr Osiewicz 2025-07-04 01:12:12 +02:00 • committed by GitHub
parent 0ebf7f54bb
commit 91bfe6f968
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 230 additions and 218 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/project/src/debugger/session.rs
View file

@ -1016,7 +1016,7 @@ impl Session {
cx.spawn(async move |this, cx| {
while let Some(output) = rx.next().await {
this.update(cx, |this, cx| {
this.update(cx, |this, _| {
let event = dap::OutputEvent {
category: None,
output,
@ -1028,7 +1028,7 @@ impl Session {
data: None,
location_reference: None,
};
this.push_output(event, cx);
this.push_output(event);
})?;
}
anyhow::Ok(())
@ -1458,7 +1458,7 @@ impl Session {
return;
}
self.push_output(event, cx);
self.push_output(event);
cx.notify();
}
Events::Breakpoint(event) => self.breakpoint_store.update(cx, |store, _| {
@ -1645,10 +1645,9 @@ impl Session {
});
}
fn push_output(&mut self, event: OutputEvent, cx: &mut Context<Self>) {
fn push_output(&mut self, event: OutputEvent) {
self.output.push_back(event);
self.output_token.0 += 1;
cx.emit(SessionEvent::ConsoleOutput);
}
pub fn any_stopped_thread(&self) -> bool {
@ -2352,7 +2351,7 @@ impl Session {
data: None,
location_reference: None,
};
self.push_output(event, cx);
self.push_output(event);
let request = self.mode.request_dap(EvaluateCommand {
expression,
context,
@ -2375,7 +2374,7 @@ impl Session {
data: None,
location_reference: None,
};
this.push_output(event, cx);
this.push_output(event);
}
Err(e) => {
let event = dap::OutputEvent {
@ -2389,7 +2388,7 @@ impl Session {
data: None,
location_reference: None,
};
this.push_output(event, cx);
this.push_output(event);
}
};
cx.notify();