From 92c21a28147c8337e9541aecdb8cd4e6c2394c25 Mon Sep 17 00:00:00 2001 From: Michael Sloan Date: Fri, 7 Feb 2025 03:29:05 -0700 Subject: [PATCH] Fix undismissed app notifications appearing on new workspaces (#24437) Bug in #23817 Release Notes: - N/A --- crates/workspace/src/notifications.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/crates/workspace/src/notifications.rs b/crates/workspace/src/notifications.rs index dacca6067e..ad491910d0 100644 --- a/crates/workspace/src/notifications.rs +++ b/crates/workspace/src/notifications.rs @@ -1,7 +1,7 @@ use crate::{Toast, Workspace}; use gpui::{ svg, AnyView, App, AppContext as _, AsyncWindowContext, ClipboardItem, Context, DismissEvent, - Entity, EventEmitter, Global, PromptLevel, Render, ScrollHandle, Task, + Entity, EventEmitter, PromptLevel, Render, ScrollHandle, Task, }; use parking_lot::Mutex; use std::sync::{Arc, LazyLock}; @@ -156,10 +156,11 @@ impl Workspace { pub fn show_initial_notifications(&mut self, cx: &mut Context) { // Allow absence of the global so that tests don't need to initialize it. - let app_notifications = cx - .try_global::() + let app_notifications = GLOBAL_APP_NOTIFICATIONS + .lock() + .app_notifications .iter() - .flat_map(|global| global.app_notifications.iter().cloned()) + .cloned() .collect::>(); for (id, build_notification) in app_notifications { self.show_notification_without_handling_dismiss_events(&id, cx, |cx| { @@ -614,8 +615,6 @@ struct AppNotifications { )>, } -impl Global for AppNotifications {} - impl AppNotifications { pub fn insert( &mut self,