From 9443c930de078bc6ebdc7c82099b05816ec68aa2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Fern=C3=A1ndez=20G=C3=B3mez?= Date: Sat, 9 Aug 2025 00:50:39 +0200 Subject: [PATCH] Make One Dark's `ansi.*magenta` colors more magenta-y (#35423) Tweak the `ansi.*magenta` colours so they are not confused with `ansi.*red`. This matches how "One Light" behaves, where `ansi.*magenta` uses the same purple as for keyword. This change helps distinguish anything that the terminal might use magenta for from errors, and helps make more readable the output of certain tools. For maintainers: The color for `ansi.magenta` is the same as for `syntax.keyword`. The others are modifications on that colour to taste. If you have some specific shades that need to be used please tell me, or feel free to take over the PR. Before: `jj log` and `difftastic` output Screenshot 2025-07-31 at 19 32 11 After: Screenshot 2025-07-31 at 19 35 33 Release Notes: - N/A --------- Co-authored-by: Danilo Leal --- assets/themes/one/one.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/assets/themes/one/one.json b/assets/themes/one/one.json index 384ad28272..23ebbcc67e 100644 --- a/assets/themes/one/one.json +++ b/assets/themes/one/one.json @@ -86,9 +86,9 @@ "terminal.ansi.blue": "#74ade8ff", "terminal.ansi.bright_blue": "#385378ff", "terminal.ansi.dim_blue": "#bed5f4ff", - "terminal.ansi.magenta": "#be5046ff", - "terminal.ansi.bright_magenta": "#5e2b26ff", - "terminal.ansi.dim_magenta": "#e6a79eff", + "terminal.ansi.magenta": "#b477cfff", + "terminal.ansi.bright_magenta": "#d6b4e4ff", + "terminal.ansi.dim_magenta": "#612a79ff", "terminal.ansi.cyan": "#6eb4bfff", "terminal.ansi.bright_cyan": "#3a565bff", "terminal.ansi.dim_cyan": "#b9d9dfff",