Always include room id in protos
This is redundant, but it futures-proof the ability to talk about multiple rooms at any given time and feels safer in terms of race conditions.
This commit is contained in:
parent
baf6097b49
commit
95e08edbb8
4 changed files with 36 additions and 8 deletions
|
@ -145,10 +145,19 @@ impl ActiveCall {
|
|||
recipient_user_id: u64,
|
||||
cx: &mut ModelContext<Self>,
|
||||
) -> Task<Result<()>> {
|
||||
let room_id = if let Some(room) = self.room() {
|
||||
room.read(cx).id()
|
||||
} else {
|
||||
return Task::ready(Err(anyhow!("no active call")));
|
||||
};
|
||||
|
||||
let client = self.client.clone();
|
||||
cx.foreground().spawn(async move {
|
||||
client
|
||||
.request(proto::CancelCall { recipient_user_id })
|
||||
.request(proto::CancelCall {
|
||||
room_id,
|
||||
recipient_user_id,
|
||||
})
|
||||
.await?;
|
||||
anyhow::Ok(())
|
||||
})
|
||||
|
@ -178,8 +187,15 @@ impl ActiveCall {
|
|||
}
|
||||
|
||||
pub fn decline_incoming(&mut self) -> Result<()> {
|
||||
*self.incoming_call.0.borrow_mut() = None;
|
||||
self.client.send(proto::DeclineCall {})?;
|
||||
let call = self
|
||||
.incoming_call
|
||||
.0
|
||||
.borrow_mut()
|
||||
.take()
|
||||
.ok_or_else(|| anyhow!("no incoming call"))?;
|
||||
self.client.send(proto::DeclineCall {
|
||||
room_id: call.room_id,
|
||||
})?;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue