Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Properly use static instead of const for global types that need a single init (#35955)

Browse source 
Release Notes:

- N/A
This commit is contained in:
Kirill Bulatov 2025-08-10 21:01:54 +03:00 • committed by GitHub
parent 9cd5c3656e
commit 95e302fa68
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 55 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

29
crates/onboarding/src/theme_preview.rs
View file

@ -1,6 +1,9 @@
#![allow(unused, dead_code)]
use gpui::{Hsla, Length};
use std::sync::Arc;
use std::{
cell::LazyCell,
sync::{Arc, OnceLock},
};
use theme::{Theme, ThemeColors, ThemeRegistry};
use ui::{
IntoElement, RenderOnce, component_prelude::Documented, prelude::*, utils::inner_corner_radius,
@ -22,6 +25,18 @@ pub struct ThemePreviewTile {
style: ThemePreviewStyle,
}
fn child_radius() -> Pixels {
static CHILD_RADIUS: OnceLock<Pixels> = OnceLock::new();
*CHILD_RADIUS.get_or_init(|| {
inner_corner_radius(
ThemePreviewTile::ROOT_RADIUS,
ThemePreviewTile::ROOT_BORDER,
ThemePreviewTile::ROOT_PADDING,
ThemePreviewTile::CHILD_BORDER,
)
})
}
impl ThemePreviewTile {
pub const SKELETON_HEIGHT_DEFAULT: Pixels = px(2.);
pub const SIDEBAR_SKELETON_ITEM_COUNT: usize = 8;
@ -30,14 +45,6 @@ impl ThemePreviewTile {
pub const ROOT_BORDER: Pixels = px(2.0);
pub const ROOT_PADDING: Pixels = px(2.0);
pub const CHILD_BORDER: Pixels = px(1.0);
pub const CHILD_RADIUS: std::cell::LazyCell<Pixels> = std::cell::LazyCell::new(|| {
inner_corner_radius(
Self::ROOT_RADIUS,
Self::ROOT_BORDER,
Self::ROOT_PADDING,
Self::CHILD_BORDER,
)
});
pub fn new(theme: Arc<Theme>, seed: f32) -> Self {
Self {
@ -222,7 +229,7 @@ impl ThemePreviewTile {
.child(
div()
.size_full()
.rounded(*Self::CHILD_RADIUS)
.rounded(child_radius())
.border(Self::CHILD_BORDER)
.border_color(theme.colors().border)
.child(Self::render_editor(
@ -250,7 +257,7 @@ impl ThemePreviewTile {
h_flex()
.size_full()
.relative()
.rounded(*Self::CHILD_RADIUS)
.rounded(child_radius())
.border(Self::CHILD_BORDER)
.border_color(border_color)
.overflow_hidden()