From 9604b22d980e4b595d91a2d1ee7221835c1c1e0a Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Tue, 26 Mar 2024 15:14:44 -0400 Subject: [PATCH] Suppress error logs from `CopilotCompletionProvider` when Copilot is disabled (#9826) This PR fixes some noisy error logs from the `CopilotCompletionProvider` when Copilot is disabled entirely via the settings. I have the following in my settings file: ```json { "features": { "copilot": false }, } ``` After #9777 I started seeing my Zed logs getting filled up with messages like this: ``` [2024-03-26T14:33:09-04:00 ERROR util] crates/copilot_ui/src/copilot_completion_provider.rs:206: copilot is disabled ``` Release Notes: - N/A --- crates/copilot_ui/src/copilot_completion_provider.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/crates/copilot_ui/src/copilot_completion_provider.rs b/crates/copilot_ui/src/copilot_completion_provider.rs index 371496a393..c50f8aa877 100644 --- a/crates/copilot_ui/src/copilot_completion_provider.rs +++ b/crates/copilot_ui/src/copilot_completion_provider.rs @@ -3,7 +3,9 @@ use client::telemetry::Telemetry; use copilot::Copilot; use editor::{Direction, InlineCompletionProvider}; use gpui::{AppContext, EntityId, Model, ModelContext, Task}; +use language::language_settings::AllLanguageSettings; use language::{language_settings::all_language_settings, Buffer, OffsetRangeExt, ToOffset}; +use settings::Settings; use std::{path::Path, sync::Arc, time::Duration}; pub const COPILOT_DEBOUNCE_TIMEOUT: Duration = Duration::from_millis(75); @@ -193,6 +195,11 @@ impl InlineCompletionProvider for CopilotCompletionProvider { } fn discard(&mut self, cx: &mut ModelContext) { + let settings = AllLanguageSettings::get_global(cx); + if !settings.copilot.feature_enabled { + return; + } + self.copilot .update(cx, |copilot, cx| { copilot.discard_completions(&self.completions, cx)