Remove unused TerminalView.has_new_content (#7429)

Found this last week with @osiewicz and we realized that it's unused. So
I think it's fine to remove it, but I want to hear whether @mikayla-maki
has some thoughts here.



Release Notes:

- N/A
This commit is contained in:
Thorsten Ball 2024-02-06 16:58:10 +01:00 committed by GitHub
parent 068c141559
commit 960eaf6245
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -77,7 +77,6 @@ pub struct TerminalView {
terminal: Model<Terminal>, terminal: Model<Terminal>,
workspace: WeakView<Workspace>, workspace: WeakView<Workspace>,
focus_handle: FocusHandle, focus_handle: FocusHandle,
has_new_content: bool,
//Currently using iTerm bell, show bell emoji in tab until input is received //Currently using iTerm bell, show bell emoji in tab until input is received
has_bell: bool, has_bell: bool,
context_menu: Option<(View<ContextMenu>, gpui::Point<Pixels>, Subscription)>, context_menu: Option<(View<ContextMenu>, gpui::Point<Pixels>, Subscription)>,
@ -142,9 +141,6 @@ impl TerminalView {
cx.observe(&terminal, |_, _, cx| cx.notify()).detach(); cx.observe(&terminal, |_, _, cx| cx.notify()).detach();
cx.subscribe(&terminal, move |this, _, event, cx| match event { cx.subscribe(&terminal, move |this, _, event, cx| match event {
Event::Wakeup => { Event::Wakeup => {
if !this.focus_handle.is_focused(cx) {
this.has_new_content = true;
}
cx.notify(); cx.notify();
cx.emit(Event::Wakeup); cx.emit(Event::Wakeup);
cx.emit(ItemEvent::UpdateTab); cx.emit(ItemEvent::UpdateTab);
@ -309,7 +305,6 @@ impl TerminalView {
Self { Self {
terminal, terminal,
workspace: workspace_handle, workspace: workspace_handle,
has_new_content: true,
has_bell: false, has_bell: false,
focus_handle, focus_handle,
context_menu: None, context_menu: None,
@ -327,10 +322,6 @@ impl TerminalView {
&self.terminal &self.terminal
} }
pub fn has_new_content(&self) -> bool {
self.has_new_content
}
pub fn has_bell(&self) -> bool { pub fn has_bell(&self) -> bool {
self.has_bell self.has_bell
} }
@ -688,7 +679,6 @@ impl TerminalView {
} }
fn focus_in(&mut self, cx: &mut ViewContext<Self>) { fn focus_in(&mut self, cx: &mut ViewContext<Self>) {
self.has_new_content = false;
self.terminal.read(cx).focus_in(); self.terminal.read(cx).focus_in();
self.blink_cursors(self.blink_epoch, cx); self.blink_cursors(self.blink_epoch, cx);
cx.notify(); cx.notify();