Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable clippy::clone_on_copy (#8728)

Browse source 
This PR enables the
[`clippy::clone_on_copy`](https://rust-lang.github.io/rust-clippy/master/index.html#/clone_on_copy)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-02 17:37:48 -05:00 • committed by GitHub
parent 5935681c5c
commit 9735912965
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
42 changed files with 144 additions and 160 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/collab_ui/src/channel_view.rs
View file

@ -171,10 +171,8 @@ impl ChannelView {
let this = this.clone();
Some(ui::ContextMenu::build(cx, move |menu, _| {
menu.entry("Copy link to section", None, move |cx| {
this.update(cx, |this, cx| {
this.copy_link_for_position(position.clone(), cx)
})
.ok();
this.update(cx, |this, cx| this.copy_link_for_position(position, cx))
.ok();
})
}))
});

2
crates/collab_ui/src/collab_titlebar_item.rs
View file

@ -403,7 +403,7 @@ impl CollabTitlebarItem {
)
})
.on_click({
let host_peer_id = host.peer_id.clone();
let host_peer_id = host.peer_id;
cx.listener(move |this, _, cx| {
this.workspace
.update(cx, |workspace, cx| {

2
crates/collab_ui/src/notifications/incoming_call_notification.rs
View file

@ -119,7 +119,7 @@ impl Render for IncomingCallNotification {
let theme_settings = ThemeSettings::get_global(cx);
(
theme_settings.ui_font.family.clone(),
theme_settings.ui_font_size.clone(),
theme_settings.ui_font_size,
)
};

2
crates/collab_ui/src/notifications/project_shared_notification.rs
View file

@ -123,7 +123,7 @@ impl Render for ProjectSharedNotification {
let theme_settings = ThemeSettings::get_global(cx);
(
theme_settings.ui_font.family.clone(),
theme_settings.ui_font_size.clone(),
theme_settings.ui_font_size,
)
};