From 97dc1d193f9a4b7cc90a63c7cc01870dbf05db79 Mon Sep 17 00:00:00 2001
From: Marshall Bowers <elliott.codes@gmail.com>
Date: Wed, 18 Sep 2024 14:24:09 -0400
Subject: [PATCH] Use `@tag.doctype` for HTML doctype highlights (#18024)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This PR updates the following extensions to use the `@tag.doctype`
selector for highlighting HTML doctypes:

- Astro
- Elixir (HEEx)
- HTML

Additionally, it also changes the base selector for HTML tags from
`@keyword` to `@tag`.

| Before | After |
|
-------------------------------------------------------------------------------------------------------------------------------------------------
|
-------------------------------------------------------------------------------------------------------------------------------------------------
|
| <img width="308" alt="Screenshot 2024-09-18 at 2 04 41 PM"
src="https://github.com/user-attachments/assets/818d98ba-fce7-4683-b67f-61c86543831c">
| <img width="358" alt="Screenshot 2024-09-18 at 2 05 00 PM"
src="https://github.com/user-attachments/assets/5071db7c-e0bf-44df-8959-38275833833b">
|

Extracted this from https://github.com/zed-industries/zed/pull/16723.

Release Notes:

- N/A

---------

Co-authored-by: 狐狸 <134658521+Huliiiiii@users.noreply.github.com>
---
 docs/src/extensions/languages.md                | 1 +
 extensions/astro/languages/astro/highlights.scm | 2 +-
 extensions/elixir/languages/heex/highlights.scm | 2 +-
 extensions/html/languages/html/highlights.scm   | 4 ++--
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/docs/src/extensions/languages.md b/docs/src/extensions/languages.md
index c003285303..174a27c6e6 100644
--- a/docs/src/extensions/languages.md
+++ b/docs/src/extensions/languages.md
@@ -123,6 +123,7 @@ This query marks strings, object keys, and numbers for highlighting. The followi
 | @string.special          | Captures special strings               |
 | @string.special.symbol   | Captures special symbols               |
 | @tag                     | Captures tags                          |
+| @tag.doctype             | Captures doctypes (e.g., in HTML)      |
 | @text.literal            | Captures literal text                  |
 | @title                   | Captures titles                        |
 | @type                    | Captures types                         |
diff --git a/extensions/astro/languages/astro/highlights.scm b/extensions/astro/languages/astro/highlights.scm
index 491e8cc337..a565e22b6e 100644
--- a/extensions/astro/languages/astro/highlights.scm
+++ b/extensions/astro/languages/astro/highlights.scm
@@ -1,6 +1,6 @@
 (tag_name) @tag
 (erroneous_end_tag_name) @keyword
-(doctype) @constant
+(doctype) @tag.doctype
 (attribute_name) @property
 (attribute_value) @string
 (comment) @comment
diff --git a/extensions/elixir/languages/heex/highlights.scm b/extensions/elixir/languages/heex/highlights.scm
index 5252b71fac..9662c95524 100644
--- a/extensions/elixir/languages/heex/highlights.scm
+++ b/extensions/elixir/languages/heex/highlights.scm
@@ -27,7 +27,7 @@
 "=" @operator
 
 ; HEEx inherits the DOCTYPE tag from HTML
-(doctype) @constant
+(doctype) @tag.doctype
 
 (comment) @comment
 
diff --git a/extensions/html/languages/html/highlights.scm b/extensions/html/languages/html/highlights.scm
index e2b8e35bf4..6bb0c23374 100644
--- a/extensions/html/languages/html/highlights.scm
+++ b/extensions/html/languages/html/highlights.scm
@@ -1,6 +1,6 @@
-(tag_name) @keyword
+(tag_name) @tag
 (erroneous_end_tag_name) @keyword
-(doctype) @constant
+(doctype) @tag.doctype
 (attribute_name) @property
 (attribute_value) @string
 (comment) @comment