Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

snippets: Read user settings for workspace configuration (#13356)

Browse source 
Fixes #13334

Use `settings` field in `lsp` subsettings to fix up the settings as
wish:
```
  "lsp": {
    "snippet-completion-server": {
      "settings": {
        "max_completion_items": 20, 
        "snippets_first": false,
        "feature_words": true,
        "feature_snippets": true,
        "feature_paths": true,
        "feature_unicode_input": false
      }
    }
  }
```


Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz 2024-06-21 12:44:19 +02:00 • committed by GitHub
parent f69c8ca74e
commit 9bdb154a9b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 21 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

40
extensions/snippets/src/snippets.rs
View file

@ -1,7 +1,7 @@
use serde_json::json;
use std::fs;
use zed::LanguageServerId;
use zed_extension_api::{self as zed, Result};
use zed_extension_api::{self as zed, settings::LspSettings, Result};
struct SnippetExtension {
cached_binary_path: Option<String>,
@ -106,32 +106,24 @@ impl zed::Extension for SnippetExtension {
})
}
fn language_server_initialization_options(
&mut self,
_language_server_id: &LanguageServerId,
_worktree: &zed_extension_api::Worktree,
) -> Result<Option<zed_extension_api::serde_json::Value>> {
Ok(Some(json!({
"max_completion_items": 20,
"snippets_first": true,
"feature_words": false,
"feature_snippets": true,
"feature_paths": true
})))
}
fn language_server_workspace_configuration(
&mut self,
_language_server_id: &LanguageServerId,
_worktree: &zed_extension_api::Worktree,
server_id: &LanguageServerId,
worktree: &zed_extension_api::Worktree,
) -> Result<Option<zed_extension_api::serde_json::Value>> {
Ok(Some(json!({
"max_completion_items": 20,
"snippets_first": true,
"feature_words": false,
"feature_snippets": true,
"feature_paths": true
})))
let settings = LspSettings::for_worktree(server_id.as_ref(), worktree)
.ok()
.and_then(|lsp_settings| lsp_settings.settings.clone())
.unwrap_or_else(|| {
json!({
"max_completion_items": 20,
"snippets_first": true,
"feature_words": false,
"feature_snippets": true,
"feature_paths": true
})
});
Ok(Some(settings))
}
}