repl: Don't send KernelInfoRequest on launch (#14608)

Closes #14146. This is just for the time being before a networking
refactoring to split reads and writes on the ROUTER/DEALER ZeroMQ
sockets. Some kernels have not been responding with `kernel_info_reply`,
which ends up hanging our shell socket.

Release Notes:

- N/A

Release notes for the REPL feature will be part of its official launch.
This commit is contained in:
Kyle Kelley 2024-07-16 15:51:23 -07:00 committed by GitHub
parent f8cfb50bb4
commit 9c43450fef
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -16,8 +16,7 @@ use gpui::{
use language::Point;
use project::Fs;
use runtimelib::{
ExecuteRequest, InterruptRequest, JupyterMessage, JupyterMessageContent, KernelInfoRequest,
ShutdownRequest,
ExecuteRequest, InterruptRequest, JupyterMessage, JupyterMessageContent, ShutdownRequest,
};
use settings::Settings as _;
use std::{ops::Range, sync::Arc, time::Duration};
@ -173,24 +172,6 @@ impl Session {
.ok();
}
});
// For some reason sending a kernel info request will brick the ark (R) kernel.
// Note that Deno and Python do not have this issue.
if this.kernel_specification.name == "ark" {
return;
}
// Get kernel info after (possibly) letting the kernel start
cx.spawn(|this, mut cx| async move {
cx.background_executor()
.timer(Duration::from_millis(120))
.await;
this.update(&mut cx, |this, _cx| {
this.send(KernelInfoRequest {}.into(), _cx).ok();
})
.ok();
})
.detach();
})
.ok();
}