Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

agent: Make the sound notification play only if Zed is in the background (#31975)

Browse source 
Users were giving feedback about the sound notification being
annoying/unnecessary if Zed is in the foreground, which I agree! So,
this PR changes it so that it only plays if that is not the case.

Release Notes:

- agent: Improved sound notification behavior by making it play only if
Zed is in the background.
This commit is contained in:
Danilo Leal 2025-06-03 11:14:26 -03:00 • committed by GitHub
parent 707a4c7f20
commit 9e75871d48
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/agent/src/active_thread.rs
View file

@ -999,7 +999,7 @@ impl ActiveThread {
ThreadEvent::Stopped(reason) => match reason { ThreadEvent::Stopped(reason) => match reason {
Ok(StopReason::EndTurn | StopReason::MaxTokens) => { Ok(StopReason::EndTurn | StopReason::MaxTokens) => {
let used_tools = self.thread.read(cx).used_tools_since_last_user_message(); let used_tools = self.thread.read(cx).used_tools_since_last_user_message();
self.play_notification_sound(cx); self.play_notification_sound(window, cx);
self.show_notification( self.show_notification(
if used_tools { if used_tools {
"Finished running tools" "Finished running tools"
@ -1014,11 +1014,11 @@ impl ActiveThread {
_ => {} _ => {}
}, },
ThreadEvent::ToolConfirmationNeeded => { ThreadEvent::ToolConfirmationNeeded => {
self.play_notification_sound(cx); self.play_notification_sound(window, cx);
self.show_notification("Waiting for tool confirmation", IconName::Info, window, cx); self.show_notification("Waiting for tool confirmation", IconName::Info, window, cx);
} }
ThreadEvent::ToolUseLimitReached => { ThreadEvent::ToolUseLimitReached => {
self.play_notification_sound(cx); self.play_notification_sound(window, cx);
self.show_notification( self.show_notification(
"Consecutive tool use limit reached.", "Consecutive tool use limit reached.",
IconName::Warning, IconName::Warning,
@ -1160,9 +1160,9 @@ impl ActiveThread {
cx.notify(); cx.notify();
} }
fn play_notification_sound(&self, cx: &mut App) { fn play_notification_sound(&self, window: &Window, cx: &mut App) {
let settings = AgentSettings::get_global(cx); let settings = AgentSettings::get_global(cx);
if settings.play_sound_when_agent_done { if settings.play_sound_when_agent_done && !window.is_window_active() {
Audio::play_sound(Sound::AgentDone, cx); Audio::play_sound(Sound::AgentDone, cx);
} }
} }