Enable clippy::iter_overeager_cloned (#8839)

This PR enables the
[`clippy::iter_overeager_cloned`](https://rust-lang.github.io/rust-clippy/master/index.html#/iter_overeager_cloned)
rule and fixes the outstanding violations.

Release Notes:

- N/A

tooling/xtask/src/main.rs

@@ -88,7 +88,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::derive_ord_xor_partial_ord",
         "clippy::eq_op",
         "clippy::implied_bounds_in_impls",
-        "clippy::iter_overeager_cloned",
         "clippy::let_underscore_future",
         "clippy::map_entry",
         "clippy::never_loop",