Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Enable clippy::manual_find (#8737)

Browse source 
This PR enables the
[`clippy::manual_find`](https://rust-lang.github.io/rust-clippy/master/index.html#/manual_find)
rule and fixes the outstanding violations.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-02 20:03:49 -05:00 • committed by GitHub
parent fc8e515fe8
commit a17c207217
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
crates/prettier/src/prettier.rs
View file

@ -245,7 +245,7 @@ impl Prettier {
); );
let plugin_name_into_path = |plugin_name: &str| { let plugin_name_into_path = |plugin_name: &str| {
let prettier_plugin_dir = prettier_node_modules.join(plugin_name); let prettier_plugin_dir = prettier_node_modules.join(plugin_name);
for possible_plugin_path in [ [
prettier_plugin_dir.join("dist").join("index.mjs"), prettier_plugin_dir.join("dist").join("index.mjs"),
prettier_plugin_dir.join("dist").join("index.js"), prettier_plugin_dir.join("dist").join("index.js"),
prettier_plugin_dir.join("dist").join("plugin.js"), prettier_plugin_dir.join("dist").join("plugin.js"),
@ -255,12 +255,9 @@ impl Prettier {
// this one is for @prettier/plugin-php // this one is for @prettier/plugin-php
prettier_plugin_dir.join("standalone.js"), prettier_plugin_dir.join("standalone.js"),
prettier_plugin_dir, prettier_plugin_dir,
] { ]
if possible_plugin_path.is_file() { .into_iter()
return Some(possible_plugin_path); .find(|possible_plugin_path| possible_plugin_path.is_file())
}
}
None
}; };
let (parser, located_plugins) = match parser_with_plugins { let (parser, located_plugins) = match parser_with_plugins {
Some((parser, plugins)) => { Some((parser, plugins)) => {

1
tooling/xtask/src/main.rs
View file

@ -101,7 +101,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
"clippy::iter_kv_map", "clippy::iter_kv_map",
"clippy::iter_overeager_cloned", "clippy::iter_overeager_cloned",
"clippy::let_underscore_future", "clippy::let_underscore_future",
"clippy::manual_find",
"clippy::manual_flatten", "clippy::manual_flatten",
"clippy::map_entry", "clippy::map_entry",
"clippy::needless_arbitrary_self_type", "clippy::needless_arbitrary_self_type",