Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

assistant: Fix copy/cut not working when selection is empty (#18403)

Browse source 
Release Notes:

- Fixed copy/cut/paste not working in the assistant panel when selection
was empty
This commit is contained in:
Bennet Bo Fenner 2024-09-27 10:51:49 +02:00 • committed by GitHub
parent 568a21a700
commit a1d2e1106e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 61 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

42
crates/assistant/src/assistant_panel.rs
View file

@ -72,6 +72,7 @@ use std::{
time::Duration, time::Duration,
}; };
use terminal_view::{terminal_panel::TerminalPanel, TerminalView}; use terminal_view::{terminal_panel::TerminalPanel, TerminalView};
use text::SelectionGoal;
use ui::TintColor; use ui::TintColor;
use ui::{ use ui::{
prelude::*, prelude::*,
@ -3438,7 +3439,7 @@ impl ContextEditor {
fn copy(&mut self, _: &editor::actions::Copy, cx: &mut ViewContext<Self>) { fn copy(&mut self, _: &editor::actions::Copy, cx: &mut ViewContext<Self>) {
if self.editor.read(cx).selections.count() == 1 { if self.editor.read(cx).selections.count() == 1 {
let (copied_text, metadata) = self.get_clipboard_contents(cx); let (copied_text, metadata, _) = self.get_clipboard_contents(cx);
cx.write_to_clipboard(ClipboardItem::new_string_with_json_metadata( cx.write_to_clipboard(ClipboardItem::new_string_with_json_metadata(
copied_text, copied_text,
metadata, metadata,
@ -3452,11 +3453,9 @@ impl ContextEditor {
fn cut(&mut self, _: &editor::actions::Cut, cx: &mut ViewContext<Self>) { fn cut(&mut self, _: &editor::actions::Cut, cx: &mut ViewContext<Self>) {
if self.editor.read(cx).selections.count() == 1 { if self.editor.read(cx).selections.count() == 1 {
let (copied_text, metadata) = self.get_clipboard_contents(cx); let (copied_text, metadata, selections) = self.get_clipboard_contents(cx);
self.editor.update(cx, |editor, cx| { self.editor.update(cx, |editor, cx| {
let selections = editor.selections.all::<Point>(cx);
editor.transact(cx, |this, cx| { editor.transact(cx, |this, cx| {
this.change_selections(Some(Autoscroll::fit()), cx, |s| { this.change_selections(Some(Autoscroll::fit()), cx, |s| {
s.select(selections); s.select(selections);
@ -3476,17 +3475,34 @@ impl ContextEditor {
cx.propagate(); cx.propagate();
} }
fn get_clipboard_contents(&mut self, cx: &mut ViewContext<Self>) -> (String, CopyMetadata) { fn get_clipboard_contents(
let creases = self.editor.update(cx, |editor, cx| { &mut self,
let selection = editor.selections.newest::<Point>(cx); cx: &mut ViewContext<Self>,
let selection_start = editor.selections.newest::<usize>(cx).start; ) -> (String, CopyMetadata, Vec<text::Selection<usize>>) {
let (snapshot, selection, creases) = self.editor.update(cx, |editor, cx| {
let mut selection = editor.selections.newest::<Point>(cx);
let snapshot = editor.buffer().read(cx).snapshot(cx); let snapshot = editor.buffer().read(cx).snapshot(cx);
let is_entire_line = selection.is_empty() || editor.selections.line_mode;
if is_entire_line {
selection.start = Point::new(selection.start.row, 0);
selection.end =
cmp::min(snapshot.max_point(), Point::new(selection.start.row + 1, 0));
selection.goal = SelectionGoal::None;
}
let selection_start = snapshot.point_to_offset(selection.start);
(
snapshot.clone(),
selection.clone(),
editor.display_map.update(cx, |display_map, cx| { editor.display_map.update(cx, |display_map, cx| {
display_map display_map
.snapshot(cx) .snapshot(cx)
.crease_snapshot .crease_snapshot
.creases_in_range( .creases_in_range(
MultiBufferRow(selection.start.row)..MultiBufferRow(selection.end.row + 1), MultiBufferRow(selection.start.row)
..MultiBufferRow(selection.end.row + 1),
&snapshot, &snapshot,
) )
.filter_map(|crease| { .filter_map(|crease| {
@ -3517,11 +3533,13 @@ impl ContextEditor {
} }
}) })
.collect::<Vec<_>>() .collect::<Vec<_>>()
}) }),
)
}); });
let selection = selection.map(|point| snapshot.point_to_offset(point));
let context = self.context.read(cx); let context = self.context.read(cx);
let selection = self.editor.read(cx).selections.newest::<usize>(cx);
let mut text = String::new(); let mut text = String::new();
for message in context.messages(cx) { for message in context.messages(cx) {
if message.offset_range.start >= selection.range().end { if message.offset_range.start >= selection.range().end {
@ -3540,7 +3558,7 @@ impl ContextEditor {
} }
} }
(text, CopyMetadata { creases }) (text, CopyMetadata { creases }, vec![selection])
} }
fn paste(&mut self, action: &editor::actions::Paste, cx: &mut ViewContext<Self>) { fn paste(&mut self, action: &editor::actions::Paste, cx: &mut ViewContext<Self>) {