Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

editor: Add toggle diagnostics to command palette (#31358)

Browse source 
Follow-up to #30316

This PR adds the `editor: toggle diagnostics` action to the comand
palette so that it can also be invoked that way.

I also ensures this, the `toggle inline diagnostics` and `toggle
minimap` actions are only registered if these are supported by the
current editor instance.

Release Notes:

- N/A
This commit is contained in:
Finn Evers 2025-05-24 22:41:02 +02:00 • committed by GitHub
parent 34be7830a3
commit a204510cfc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/editor/src/editor.rs
View file

@ -15446,8 +15446,7 @@ impl Editor {
.max_severity .max_severity
.unwrap_or(self.diagnostics_max_severity); .unwrap_or(self.diagnostics_max_severity);
if self.mode.is_minimap() if !self.inline_diagnostics_enabled()
|| !self.inline_diagnostics_enabled()
|| !self.show_inline_diagnostics || !self.show_inline_diagnostics
|| max_severity == DiagnosticSeverity::Off || max_severity == DiagnosticSeverity::Off
{ {

11
crates/editor/src/element.rs
View file

@ -426,8 +426,15 @@ impl EditorElement {
register_action(editor, window, Editor::toggle_indent_guides); register_action(editor, window, Editor::toggle_indent_guides);
register_action(editor, window, Editor::toggle_inlay_hints); register_action(editor, window, Editor::toggle_inlay_hints);
register_action(editor, window, Editor::toggle_edit_predictions); register_action(editor, window, Editor::toggle_edit_predictions);
register_action(editor, window, Editor::toggle_inline_diagnostics); if editor.read(cx).diagnostics_enabled() {
register_action(editor, window, Editor::toggle_minimap); register_action(editor, window, Editor::toggle_diagnostics);
}
if editor.read(cx).inline_diagnostics_enabled() {
register_action(editor, window, Editor::toggle_inline_diagnostics);
}
if editor.read(cx).supports_minimap(cx) {
register_action(editor, window, Editor::toggle_minimap);
}
register_action(editor, window, hover_popover::hover); register_action(editor, window, hover_popover::hover);
register_action(editor, window, Editor::reveal_in_finder); register_action(editor, window, Editor::reveal_in_finder);
register_action(editor, window, Editor::copy_path); register_action(editor, window, Editor::copy_path);