Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use Box instead of Rc for List event handlers

Browse source
This commit is contained in:
Max Brunsfeld 2023-12-11 15:18:09 -08:00
parent 149e90c3d9
commit a208229a2c
3 changed files with 13 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/ui2/src/components/disclosure.rs
View file

@ -1,14 +1,10 @@
use std::rc::Rc;
use crate::{prelude::*, Color, Icon, IconButton, IconSize};
use gpui::ClickEvent;
use crate::prelude::*;
use crate::{Color, Icon, IconButton, IconSize};
#[derive(IntoElement)]
pub struct Disclosure {
is_open: bool,
on_toggle: Option<Rc<dyn Fn(&ClickEvent, &mut WindowContext) + 'static>>,
on_toggle: Option<Box<dyn Fn(&ClickEvent, &mut WindowContext) + 'static>>,
}
impl Disclosure {
@ -21,7 +17,7 @@ impl Disclosure {
pub fn on_toggle(
mut self,
handler: impl Into<Option<Rc<dyn Fn(&ClickEvent, &mut WindowContext) + 'static>>>,
handler: impl Into<Option<Box<dyn Fn(&ClickEvent, &mut WindowContext) + 'static>>>,
) -> Self {
self.on_toggle = handler.into();
self