Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Clean up edit predictions settings (#24692)

Browse source 
This PR does some clean up for the edit predictions settings:

- Removed `editor.show_edit_predictions_in_menu`
- Renamed `edit_predictions.inline_preview` to `edit_predictions.mode`

Release Notes:

- N/A

---------

Co-authored-by: Agus Zubiaga <agus@zed.dev>
This commit is contained in:
Marshall Bowers 2025-02-11 16:33:31 -05:00 • committed by GitHub
parent 636253d2dc
commit a2592a3a37
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 36 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

16
crates/inline_completion_button/src/inline_completion_button.rs
View file

@ -551,9 +551,9 @@ impl InlineCompletionButton {
);
}
let is_eager_preview_enabled = match settings.inline_completions_preview_mode() {
language::InlineCompletionPreviewMode::Auto => true,
language::InlineCompletionPreviewMode::WhenHoldingModifier => false,
let is_eager_preview_enabled = match settings.edit_predictions_mode() {
language::EditPredictionsMode::Auto => false,
language::EditPredictionsMode::EagerPreview => true,
};
menu = menu.separator().toggleable_entry(
"Eager Preview",
@ -567,17 +567,17 @@ impl InlineCompletionButton {
fs.clone(),
cx,
move |settings, _cx| {
let inline_preview = match is_eager_preview_enabled {
true => language::InlineCompletionPreviewMode::WhenHoldingModifier,
false => language::InlineCompletionPreviewMode::Auto,
let new_mode = match is_eager_preview_enabled {
true => language::EditPredictionsMode::Auto,
false => language::EditPredictionsMode::EagerPreview,
};
if let Some(edit_predictions) = settings.edit_predictions.as_mut() {
edit_predictions.inline_preview = inline_preview;
edit_predictions.mode = new_mode;
} else {
settings.edit_predictions =
Some(language_settings::EditPredictionSettingsContent {
inline_preview,
mode: new_mode,
..Default::default()
});
}