Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix panic in completions menu

Browse source 
We were shifting all the positions while keeping the original
string, which caused problems later when combining highlighted
ranges with matched indices.
This commit is contained in:
Antonio Scandurra 2023-12-22 12:12:39 +01:00
parent 3de72f8366
commit a551647ec1
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/editor2/src/editor.rs
View file

@ -1350,15 +1350,15 @@ impl CompletionsMenu {
completion.sort_key(),
)
});
drop(completions);
for mat in &mut matches {
let completions = self.completions.read();
let filter_start = completions[mat.candidate_id].label.filter_range.start;
let completion = &completions[mat.candidate_id];
mat.string = completion.label.text.clone();
for position in &mut mat.positions {
*position += filter_start;
*position += completion.label.filter_range.start;
}
}
drop(completions);
self.matches = matches.into();
self.selected_item = 0;