Remove into SelectionEffects from .change_selections (#33554)

Browse source

In #32656 I generalized the argument to change selections to allow
controling both the scroll and the nav history (and the completion
trigger).

To avoid conflicting with ongoing debugger cherry-picks I left the
argument as an `impl Into<>`, but I think it's clearer to make callers
specify what they want here.

I converted a lot of `None` arguments to `SelectionEffects::no_scroll()`
to be exactly compatible; but I think many people used none as an "i
don't care" value in which case Default::default() might be more
appropraite

Closes #ISSUE

Release Notes:

- N/A

...

This commit is contained in:

Conrad Irwin 2025-06-27 14:31:31 -06:00 • committed by GitHub

parent 6e762d9c05

commit a675ca7a1e

No known key found for this signature in database

GPG key ID: B5690EEEBB952194

65 changed files with 837 additions and 625 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

381

crates/editor/src/editor.rs

View file

File diff suppressed because it is too large Load diff