Enable clippy::needless_question_mark (#8759)

This PR enables the
[`clippy::needless_question_mark`](https://rust-lang.github.io/rust-clippy/master/index.html#/needless_question_mark)
rule and fixes the outstanding violations.

Release Notes:

- N/A

tooling/xtask/src/main.rs

@@ -100,7 +100,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
         "clippy::map_entry",
         "clippy::needless_lifetimes",
         "clippy::needless_option_as_deref",
-        "clippy::needless_question_mark",
         "clippy::needless_update",
         "clippy::never_loop",
         "clippy::non_canonical_clone_impl",