Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Migrate more events to telemetry::event! macro (#24102)

Browse source 
I believe this takes care of the remaining events running through the
old flow that requires transformation at the collab server level. I
think all events are now going through `telemetry::event!()`.

For anyone curious where the new telemetry names are coming from, you
can check the `for_snowflake` function within
`crates/collab/src/api/events.rs`, to see how collab is currently
transforming the events going through the old flow.

Release Notes:

- N/A
This commit is contained in:
Joseph T. Lyons 2025-02-03 11:38:45 -05:00 • committed by GitHub
parent a864168c27
commit a8741dc310
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
16 changed files with 88 additions and 150 deletions
Download patch file Download diff file Expand all files Collapse all files

23
crates/recent_projects/src/remote_servers.rs
View file

@ -201,20 +201,8 @@ impl ProjectPicker {
});
cx.new(|cx| {
let workspace = Workspace::new(
None,
project.clone(),
app_state.clone(),
window,
cx,
);
workspace
.client()
.telemetry()
.report_app_event("create ssh project".to_string());
workspace
telemetry::event!("SSH Project Created");
Workspace::new(None, project.clone(), app_state.clone(), window, cx)
})
})
.log_err();
@ -420,12 +408,7 @@ impl RemoteServerProjects {
match connection.await {
Some(Some(client)) => this
.update(&mut cx, |this, cx| {
let _ = this.workspace.update(cx, |workspace, _| {
workspace
.client()
.telemetry()
.report_app_event("create ssh server".to_string())
});
telemetry::event!("SSH Server Created");
this.retained_connections.push(client);
this.add_ssh_server(connection_options, cx);
this.mode = Mode::default_mode(cx);