Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use Vec for KeyContext instead of SmallVec (#24916)

Browse source 
In Zed the key context almost always has more than 1 entry, so use of
`SmallVec` is just adding overhead.

In Zed while using the editor this typically has more than 8 entries.
Since `ContextEntry` is 48 bytes, if this were made to be a
`SmallVec<[ContextEntry; 10]>` then it would use 480 bytes on the stack,
which to me seems like a lot to be copying. So, instead opting to just
use `Vec`

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-02-17 12:43:28 -07:00 • committed by GitHub
parent f2bc3d3738
commit aa4c438f83
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/gpui/src/keymap/context.rs
View file

@ -1,6 +1,5 @@
use crate::SharedString; use crate::SharedString;
use anyhow::{anyhow, Result}; use anyhow::{anyhow, Result};
use smallvec::SmallVec;
use std::fmt; use std::fmt;
/// A datastructure for resolving whether an action should be dispatched /// A datastructure for resolving whether an action should be dispatched
@ -8,7 +7,7 @@ use std::fmt;
/// and/or key value pairs representing the current context for the /// and/or key value pairs representing the current context for the
/// keymap. /// keymap.
#[derive(Clone, Default, Eq, PartialEq, Hash)] #[derive(Clone, Default, Eq, PartialEq, Hash)]
pub struct KeyContext(SmallVec<[ContextEntry; 1]>); pub struct KeyContext(Vec<ContextEntry>);
#[derive(Clone, Debug, Eq, PartialEq, Hash)] #[derive(Clone, Debug, Eq, PartialEq, Hash)]
/// An entry in a KeyContext /// An entry in a KeyContext