Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add typo detection to CI (#4107)

Browse source 
Adding the typos crate to our CI will take some doing, as we have
several tests which rely on typos in various ways (e.g. checking state
as the user types), but I thought I'd take a first stab at fixing what
it finds.

Release Notes:

- N/A
This commit is contained in:
Mikayla Maki 2024-01-17 17:13:47 -08:00 • committed by GitHub
commit aa7351041d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
64 changed files with 146 additions and 114 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/collab/src/tests/channel_tests.rs
View file

@ -203,7 +203,7 @@ async fn test_core_channels(
executor.run_until_parked();
// Observe that client B is now an admin of channel A, and that
// their admin priveleges extend to subchannels of channel A.
// their admin privileges extend to subchannels of channel A.
assert_channel_invitations(client_b.channel_store(), cx_b, &[]);
assert_channels(
client_b.channel_store(),

10
crates/collab/src/tests/editor_tests.rs
View file

@ -1192,7 +1192,7 @@ async fn test_on_input_format_from_host_to_guest(
executor.run_until_parked();
// Receive an OnTypeFormatting request as the host's language server.
// Return some formattings from the host's language server.
// Return some formatting from the host's language server.
fake_language_server.handle_request::<lsp::request::OnTypeFormatting, _, _>(
|params, _| async move {
assert_eq!(
@ -1211,7 +1211,7 @@ async fn test_on_input_format_from_host_to_guest(
},
);
// Open the buffer on the guest and see that the formattings worked
// Open the buffer on the guest and see that the formatting worked
let buffer_b = project_b
.update(cx_b, |p, cx| p.open_buffer((worktree_id, "main.rs"), cx))
.await
@ -1327,7 +1327,7 @@ async fn test_on_input_format_from_guest_to_host(
});
// Receive an OnTypeFormatting request as the host's language server.
// Return some formattings from the host's language server.
// Return some formatting from the host's language server.
executor.start_waiting();
fake_language_server
.handle_request::<lsp::request::OnTypeFormatting, _, _>(|params, _| async move {
@ -1350,7 +1350,7 @@ async fn test_on_input_format_from_guest_to_host(
.unwrap();
executor.finish_waiting();
// Open the buffer on the host and see that the formattings worked
// Open the buffer on the host and see that the formatting worked
let buffer_a = project_a
.update(cx_a, |p, cx| p.open_buffer((worktree_id, "main.rs"), cx))
.await
@ -1824,7 +1824,7 @@ async fn test_inlay_hint_refresh_is_forwarded(
assert_eq!(
inlay_cache.version(),
1,
"Should update cache verison after first hints"
"Should update cache version after first hints"
);
});

7
crates/collab/src/tests/following_tests.rs
View file

@ -1737,6 +1737,11 @@ async fn test_following_into_excluded_file(
vec![18..17]
);
editor_for_excluded_a.update(cx_a, |editor, cx| {
editor.select_right(&Default::default(), cx);
});
executor.run_until_parked();
// Changes from B to the excluded file are replicated in A's editor
editor_for_excluded_b.update(cx_b, |editor, cx| {
editor.handle_input("\nCo-Authored-By: B <b@b.b>", cx);
@ -1745,7 +1750,7 @@ async fn test_following_into_excluded_file(
editor_for_excluded_a.update(cx_a, |editor, cx| {
assert_eq!(
editor.text(cx),
"new commit messag\nCo-Authored-By: B <b@b.b>"
"new commit message\nCo-Authored-By: B <b@b.b>"
);
});
}